Update peerDependencies to support Angular 4 #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any chance of this getting merged soon? |
|
This would help us greatly |
|
@macq-vram actually found ngrx-datatable it's the newer version of this library |
|
@bassrock ngrx-datatable seems to be the newer version of "angular2-data-table", a different project to this one. (Note: the hyphen between data and table). I do not know if the two projects are similar but I did find out that substituting this project for ngrx-datatable threw up loads of compile errors! |
|
Please complete this pull request since it is badly needed :) |
hkusulja
approved these changes
Jul 24, 2017
|
+1 for this, we are trying to incorporate shrinkwrap into our build process and this error is preventing us. |
SublimePotato
approved these changes
Aug 17, 2017
|
+1 please :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids warnings when using angular2-datatable with the latest stable version of Angular.
We should possibly also update the devDependencies, but it's not as crucial as these are not giving any warnings.