Format signatures in LSP hover and completion documentation #4864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Remove short-circuit that was used to take a snapshot
krassowski
force-pushed
the
format-signatures
branch
from
2217081 to
cb6e432
Compare
krassowski
force-pushed
the
format-signatures
branch
from
1ab7ed2 to
cdf2df7
Compare
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.13.7-dev34 |
4 tasks
mscolnick
pushed a commit
that referenced
this pull request
Jul 10, 2025
## 📝 Summary This is a follow-up to #4864 since the signature-formatting capability was incorporated directly into `python-lsp-server` ## 🔍 Description of Changes Removed custom plugin and typechecking dependency on `python-lsp-server`, added configuration to prefer `ruff` if enabled over `black` (default in `python-lsp-server`). This should remain in draft pending a new release of `python-lsp-server`. ## 📋 Checklist - [x] I have read the [contributor guidelines](https://github.com/marimo-team/marimo/blob/main/CONTRIBUTING.md). - [ ] For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on [Discord](https://marimo.io/discord?ref=pr), or the community [discussions](https://github.com/marimo-team/marimo/discussions) (Please provide a link if applicable). - [ ] I have added tests for the changes made. - [ ] I have run the code and verified that it works as expected. ## 📜 Reviewers mscolnick --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Light2Dark
pushed a commit
that referenced
this pull request
Jul 14, 2025
## 📝 Summary This is a follow-up to #4864 since the signature-formatting capability was incorporated directly into `python-lsp-server` ## 🔍 Description of Changes Removed custom plugin and typechecking dependency on `python-lsp-server`, added configuration to prefer `ruff` if enabled over `black` (default in `python-lsp-server`). This should remain in draft pending a new release of `python-lsp-server`. ## 📋 Checklist - [x] I have read the [contributor guidelines](https://github.com/marimo-team/marimo/blob/main/CONTRIBUTING.md). - [ ] For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on [Discord](https://marimo.io/discord?ref=pr), or the community [discussions](https://github.com/marimo-team/marimo/discussions) (Please provide a link if applicable). - [ ] I have added tests for the changes made. - [ ] I have run the code and verified that it works as expected. ## 📜 Reviewers mscolnick --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
sebbeutler
pushed a commit
to sebbeutler/marimo
that referenced
this pull request
Jul 16, 2025
## 📝 Summary This is a follow-up to marimo-team#4864 since the signature-formatting capability was incorporated directly into `python-lsp-server` ## 🔍 Description of Changes Removed custom plugin and typechecking dependency on `python-lsp-server`, added configuration to prefer `ruff` if enabled over `black` (default in `python-lsp-server`). This should remain in draft pending a new release of `python-lsp-server`. ## 📋 Checklist - [x] I have read the [contributor guidelines](https://github.com/marimo-team/marimo/blob/main/CONTRIBUTING.md). - [ ] For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on [Discord](https://marimo.io/discord?ref=pr), or the community [discussions](https://github.com/marimo-team/marimo/discussions) (Please provide a link if applicable). - [ ] I have added tests for the changes made. - [ ] I have run the code and verified that it works as expected. ## 📜 Reviewers mscolnick --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
🔍 Description of Changes
Adds
pylsp_signatures_to_markdownhook, re-using existingruffformatting utility.Note: this does not help with
pd.read_csv; I am not sure why it is not hitting this code path, but notably it happens on the completion items which do not have a docstring either.📋 Checklist
📜 Reviewers
@mscolnick