fix: validate native ArrayBuffer sizes - #1642
Open
huytdps13400 wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
mrousavy
requested changes
Sep 8, 2026
Comment on lines
82
to
92
| std::shared_ptr<ArrayBuffer> HybridNitroModulesProxy::createNativeArrayBuffer(double size) { | ||
| const double maximumSizeExclusive = std::ldexp(1.0, std::numeric_limits<size_t>::digits); | ||
| if (!std::isfinite(size) || size < 0 || size >= maximumSizeExclusive) [[unlikely]] { | ||
| throw std::invalid_argument("ArrayBuffer size must be finite, non-negative, and within the platform size limit."); | ||
| } | ||
| return ArrayBuffer::allocate(static_cast<size_t>(size)); | ||
| } |
Member
There was a problem hiding this comment.
Why here instead of inside ArrayBuffer::allocate(..) directly? Also not sure if we should even catch this, I mean allocating NaN buffers is honestly a user mistake.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Breaking changes
None. Valid non-negative sizes keep the existing conversion and allocation behavior. Invalid values now throw deterministically instead of reaching an undefined conversion or allocation attempt.
Verification
AI assistance
Codex using GPT-5.6 Sol assisted with reproduction, implementation, tests, and review.
Fixes #1545