ci: reuse the Gradle daemon for benchmark builds - #1628
Open
mrousavy wants to merge 4 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
mrousavy
force-pushed
the
ci/reuse-benchmark-gradle-daemon
branch
from
September 7, 2026 19:02
dc7ec6b to
41bfd38
Compare
This comment has been minimized.
This comment has been minimized.
mrousavy
marked this pull request as ready for review
September 7, 2026 19:20
Member
Author
|
@nitro-modules-bot please test performance |
This comment has been minimized.
This comment has been minimized.
Member
Author
|
@nitro-modules-bot please test performance |
This comment has been minimized.
This comment has been minimized.
Member
Author
|
@nitro-modules-bot please test performance |
This comment has been minimized.
This comment has been minimized.
Member
Author
|
https://github.com/nitro-modules-bot please test performance |
Member
Author
|
@nitro-modules-bot please test performance |
This comment has been minimized.
This comment has been minimized.
Member
Author
|
@nitro-modules-bot please test performance |
Performance ReportiOS
All Benchmarks
Android
All Benchmarks
Benchmarking Code Diff Raw measurements and artifactsRaw measurements: performance-report-1 (JSON artifact). Run 34351445968, attempt 1. Download requires GitHub access. Android: measurements, attempt 1, apps, attempt 1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The paired Android benchmark build currently starts and stops a single-use Gradle daemon for each revision. Remove
--no-daemonso compatible head and base builds in the same job can reuse the daemon. The existing Gradle build cache stays enabled; device measurements run in a separate job.All checks passed on
41bfd38dd663f12f33ef625e6bc10a9867cc6fcd, including both native builds and both measurement jobs in run 34154006746. Bash syntax, ShellCheck, artifact selection and app-isolation tests also passed.Build timing review:
The current head and two controls share the same main base, runner class and restored Gradle cache. Their task counts match: head executes 140 tasks with 64 cached; base executes 135 with 69 cached. Both daemon runs start one reusable JVM, while the controls start two single-use daemons. The earlier run's Android build passed before the workflow was cancelled by the rebase.
The second build benefits from reuse, but a reduction in total build time is not demonstrated by these separate hosted runs. Their build/package timings overlap. Keep the PR open pending stronger timing evidence; current results do not justify claiming an overall speedup.