ci: cache benchmark gems for both revisions - #1627
Draft
mrousavy wants to merge 1 commit into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
mrousavy
force-pushed
the
ci/ruby-3.3.12
branch
from
September 7, 2026 19:02
8eea481 to
c0df74b
Compare
mrousavy
force-pushed
the
ci/cache-benchmark-ruby-gems
branch
from
September 7, 2026 19:02
040b31c to
921a978
Compare
Performance Report
iOS
All Benchmarks
Android
All Benchmarks
Benchmarking Code Diff Raw measurements: performance-report-1 (JSON artifact). Run 34154015570, attempt 1. Download requires GitHub access. Android: measurements, attempt 1, apps, attempt 1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Performance CI currently installs benchmark gems from scratch in both checkouts. Enable
ruby/setup-ruby's Bundler cache separately for head and base, letting the action key each cache by its checkout path, Ruby version and Gemfile.lock. Identical revisions skip the base setup because they reuse the head app.The build script now checks the installed bundle before falling back to installation, so CI reuses the action's dependencies and standalone local builds still install missing gems.
Stacked on #1624 for the Ruby 3.3.12 upgrade.
Validation:
bundle checkand CocoaPods 1.16.2 passed without changing either lockfile.git diff --checkpass. Existing Blacksmith runner labels were excluded from actionlint; no new shellcheck diagnostics were introduced.Hosted cache restore performance still needs a warm CI run; the first run can populate the caches.
Before the refresh onto the publisher rollout on main, commit
040b31c26passed hosted validation: https://github.com/margelo/nitro/actions/runs/34153344045/job/101840132508. Both checkout caches uploaded successfully, bothbundle checkcalls reused installed dependencies, and both simulator apps built successfully. These results validate the previous revision; the refreshed revision receives new hosted checks.