Revert error handling change in KeycloakAdmin.get_group_by_path
#676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominik-korsa
requested review from
marcospereirampj and
ryshoooo
as code owners
…ath` This change was introduced in marcospereirampj#627
dominik-korsa
force-pushed
the
hotfix/group-not-found
branch
from
de216a2 to
2d90827
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #675.
The reverted change was introduced in #627.
Please note that just as #627, this is a breaking change, but it might be acceptable, as raising an exception should not make existing code incorrect.