-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace delegate based server impl with call handler #102
Open
marcoferrer
wants to merge
20
commits into
master
Choose a base branch
from
server-call-handler-impl
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #102 +/- ##
=============================================
- Coverage 87.8% 65.29% -22.51%
- Complexity 21 22 +1
=============================================
Files 16 19 +3
Lines 369 608 +239
Branches 50 75 +25
=============================================
+ Hits 324 397 +73
- Misses 26 183 +157
- Partials 19 28 +9
Continue to review full report at Codecov.
|
marcoferrer
force-pushed
the
server-call-handler-impl
branch
from
January 12, 2020 17:21
51f2db5
to
9bd2cde
Compare
marcoferrer
force-pushed
the
server-call-handler-impl
branch
from
January 12, 2020 17:47
9bd2cde
to
27e77d7
Compare
marcoferrer
force-pushed
the
server-call-handler-impl
branch
from
January 13, 2020 00:20
30eb80f
to
7e3ae1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.