-
Notifications
You must be signed in to change notification settings - Fork 1
Conversation
If |
(I've reviewed all files except the main one, symsrv-fetch.py, which I will review as soon as I get the chance) |
skiplist in fact was not used. I just let it for legacy and as a reminder that we've maybe something to do. |
Another possible improvement could be to start parsing right after you fetch, instead of fetching all and then parsing all. I think we can file this as a follow-up though, as it'd be a larger change and not really worth it given the already short duration of the task you achieved. |
My Python-fu is weak and my Docker knowledge is nil, but I'm testing locally to see if the output looks sane. It will take a minute because Gentoo currently defaults to Python 3.6 and this needs 3.7 to run. |
To test locally:
|
I rewrote the file: symsrv-fetch.py:
@gabrielesvelto don't hesitate to comment here if you see something wrong.
To run it locally (to be adapted):
@gabrielesvelto, please have a look at the generated foo.zip to see if everything is ok.