Add extra settings fields #48
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clydebarrow
reviewed
Aug 2, 2023
| @@ -141,10 +141,19 @@ class ES(Inverter): | |||
| Integer("bp_pv_discharge", 38, "BP PV Discharge"), | |||
| Integer("bp_bms_protocol", 40, "BP BMS Protocol"), | |||
| Integer("power_factor", 42, "Power Factor"), | |||
| Integer("float_voltage", 44, "Float Voltage"), | |||
There was a problem hiding this comment.
Float voltage should be type Decimal with precision 10 (it's expressed in units of 0.1V)
clydebarrow
reviewed
Aug 2, 2023
| Integer("grid_export_limit", 52, "Grid Export Limit", "W", Kind.GRID), | ||
| Integer("battery_soc_protection", 56, "Battery SoC Protection", "", Kind.BAT), | ||
| Integer("battery_soc_protection", 56, "Battery SoC Protection", "", Kind.BAT), | ||
| Integer("average_voltage", 60, "Average Voltage"), |
There was a problem hiding this comment.
Any idea what this represents? It shows on my inverter as 550, so too high to be PV or mains voltage, so I suspect it might be battery voltage, in which case it would represent 55.0V - i.e. in 0.1V units.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.