Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add UseEditable::new_in_hook for manual creation of editable content #933

Merged
merged 3 commits into from
Sep 28, 2024

Conversation

marc2332
Copy link
Owner

No description provided.

@marc2332 marc2332 added the enhancement 🔥 New feature or request label Sep 27, 2024
@marc2332 marc2332 added this to the 0.3.0 milestone Sep 27, 2024
Copy link

Benchmark for 85a6509

Click to view benchmark
Test Base PR %
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached 103.0±0.47ms 103.0±0.44ms 0.00%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached 23.7±0.90ms 28.0±1.38ms +18.14%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached 1365.9±11.57µs 1378.7±12.41µs +0.94%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached 132.0±1.86µs 133.8±2.22µs +1.36%
benchmarks/size=131071 depth=17 wide=2 mode=not cached 24.2±0.69ms 27.2±0.59ms +12.40%
benchmarks/size=16383 depth=14 wide=2 mode=not cached 1685.9±10.61µs 1912.9±162.77µs +13.46%
benchmarks/size=19531 depth=7 wide=5 mode=cached 320.0±9.65µs 316.0±1.87µs -1.25%
benchmarks/size=19531 depth=7 wide=5 mode=not cached 2.5±0.05ms 2.6±0.02ms +4.00%
benchmarks/size=4095 depth=12 wide=2 mode=not cached 410.8±60.32µs 412.9±56.26µs +0.51%
benchmarks/size=54241 depth=5 wide=15 mode=cached 252.8±12.50µs 249.2±8.10µs -1.42%
benchmarks/size=54241 depth=5 wide=15 mode=not cached 6.2±0.31ms 6.8±0.61ms +9.68%

@marc2332 marc2332 marked this pull request as ready for review September 28, 2024 08:27
Copy link

Benchmark for e170f66

Click to view benchmark
Test Base PR %
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached 104.1±0.79ms 103.9±1.49ms -0.19%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached 24.2±0.78ms 25.3±0.96ms +4.55%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached 1350.5±18.28µs 1388.4±15.65µs +2.81%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached 131.6±1.64µs 132.8±4.54µs +0.91%
benchmarks/size=131071 depth=17 wide=2 mode=not cached 23.5±0.31ms 23.6±0.39ms +0.43%
benchmarks/size=16383 depth=14 wide=2 mode=not cached 1683.4±11.43µs 1687.7±39.41µs +0.26%
benchmarks/size=19531 depth=7 wide=5 mode=cached 329.4±12.47µs 314.8±8.02µs -4.43%
benchmarks/size=19531 depth=7 wide=5 mode=not cached 2.6±0.03ms 2.6±0.03ms 0.00%
benchmarks/size=4095 depth=12 wide=2 mode=not cached 415.6±152.72µs 410.9±84.89µs -1.13%
benchmarks/size=54241 depth=5 wide=15 mode=cached 252.1±17.00µs 250.6±13.35µs -0.60%
benchmarks/size=54241 depth=5 wide=15 mode=not cached 6.1±0.07ms 6.2±0.18ms +1.64%

Copy link

codecov bot commented Sep 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.05%. Comparing base (4e4afaf) to head (65ccde9).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #933   +/-   ##
=======================================
  Coverage   76.05%   76.05%           
=======================================
  Files         207      207           
  Lines       23298    23303    +5     
=======================================
+ Hits        17719    17724    +5     
  Misses       5579     5579           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marc2332 marc2332 merged commit 0507fca into main Sep 28, 2024
2 of 5 checks passed
@marc2332 marc2332 deleted the feat/manual-creation-for-use-editable branch September 28, 2024 08:52
Copy link

Benchmark for dbdbc99

Click to view benchmark
Test Base PR %
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached 104.9±0.67ms 103.7±0.73ms -1.14%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached 25.7±0.74ms 26.1±1.20ms +1.56%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached 1352.3±23.32µs 1372.0±18.61µs +1.46%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached 132.5±1.34µs 132.8±2.50µs +0.23%
benchmarks/size=131071 depth=17 wide=2 mode=not cached 25.7±0.61ms 25.1±0.83ms -2.33%
benchmarks/size=16383 depth=14 wide=2 mode=not cached 1746.5±48.16µs 1710.7±53.57µs -2.05%
benchmarks/size=19531 depth=7 wide=5 mode=cached 343.8±17.62µs 326.3±10.02µs -5.09%
benchmarks/size=19531 depth=7 wide=5 mode=not cached 2.6±0.14ms 2.5±0.03ms -3.85%
benchmarks/size=4095 depth=12 wide=2 mode=not cached 411.2±153.72µs 414.9±179.06µs +0.90%
benchmarks/size=54241 depth=5 wide=15 mode=cached 325.7±171.83µs 283.6±40.55µs -12.93%
benchmarks/size=54241 depth=5 wide=15 mode=not cached 6.5±0.24ms 6.2±0.16ms -4.62%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🔥 New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant