Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use the real text height for layout #932

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

marc2332
Copy link
Owner

@marc2332 marc2332 commented Sep 27, 2024

Otherwise some characters might get cut.

@marc2332 marc2332 added the fix 🩹 Fixes a bug label Sep 27, 2024
@marc2332 marc2332 added this to the 0.3.0 milestone Sep 27, 2024
@marc2332 marc2332 self-assigned this Sep 27, 2024
@marc2332 marc2332 marked this pull request as ready for review September 27, 2024 17:02
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.03%. Comparing base (4e4afaf) to head (df3d56d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #932      +/-   ##
==========================================
- Coverage   76.05%   76.03%   -0.02%     
==========================================
  Files         207      207              
  Lines       23298    23299       +1     
==========================================
- Hits        17719    17716       -3     
- Misses       5579     5583       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix 🩹 Fixes a bug
Projects
Status: Pending for Review
Development

Successfully merging this pull request may close these issues.

1 participant