Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Custom scale factor shortcuts #931

Merged
merged 2 commits into from
Sep 28, 2024

Conversation

marc2332
Copy link
Owner

Closes #57

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 21 lines in your changes missing coverage. Please review.

Project coverage is 75.99%. Comparing base (4e4afaf) to head (8bd6ed6).

Files with missing lines Patch % Lines
crates/renderer/src/renderer.rs 0.00% 19 Missing ⚠️
crates/renderer/src/app.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #931      +/-   ##
==========================================
- Coverage   76.05%   75.99%   -0.06%     
==========================================
  Files         207      207              
  Lines       23298    23316      +18     
==========================================
  Hits        17719    17719              
- Misses       5579     5597      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marc2332
Copy link
Owner Author

marc2332 commented Sep 27, 2024

TODO: Use command in mac

@marc2332 marc2332 marked this pull request as ready for review September 27, 2024 21:54
@marc2332 marc2332 merged commit b4f05d4 into main Sep 28, 2024
4 of 7 checks passed
@marc2332 marc2332 deleted the feat/custom-scale-factor-shortcuts branch September 28, 2024 09:08
Copy link

Benchmark for 2926da9

Click to view benchmark
Test Base PR %
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached 107.2±1.18ms 103.0±0.58ms -3.92%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached 24.5±1.60ms 23.4±1.06ms -4.49%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached 1381.9±12.46µs 1352.6±64.09µs -2.12%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached 132.2±2.21µs 132.1±2.80µs -0.08%
benchmarks/size=131071 depth=17 wide=2 mode=not cached 26.4±0.87ms 25.4±0.88ms -3.79%
benchmarks/size=16383 depth=14 wide=2 mode=not cached 1707.4±14.43µs 1774.4±69.69µs +3.92%
benchmarks/size=19531 depth=7 wide=5 mode=cached 390.1±34.53µs 343.9±22.72µs -11.84%
benchmarks/size=19531 depth=7 wide=5 mode=not cached 3.6±0.57ms 2.7±0.08ms -25.00%
benchmarks/size=4095 depth=12 wide=2 mode=not cached 426.3±85.39µs 411.9±86.53µs -3.38%
benchmarks/size=54241 depth=5 wide=15 mode=cached 353.5±97.38µs 278.6±99.09µs -21.19%
benchmarks/size=54241 depth=5 wide=15 mode=not cached 6.5±0.21ms 6.2±0.10ms -4.62%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🔥 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enhancement: Zoom support
1 participant