Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Vertical direction for Slider #910

Merged
merged 5 commits into from
Sep 28, 2024

Conversation

marc2332
Copy link
Owner

Closes #908

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 78.31325% with 18 lines in your changes missing coverage. Please review.

Project coverage is 76.00%. Comparing base (90f2bfb) to head (194c7b9).
Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
crates/components/src/slider.rs 78.31% 18 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #910      +/-   ##
==========================================
- Coverage   76.06%   76.00%   -0.06%     
==========================================
  Files         207      207              
  Lines       23296    23334      +38     
==========================================
+ Hits        17719    17736      +17     
- Misses       5577     5598      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marc2332 marc2332 marked this pull request as ready for review September 24, 2024 14:39
@marc2332 marc2332 added this to the 0.3.0 milestone Sep 27, 2024
@marc2332 marc2332 merged commit bdedb2a into main Sep 28, 2024
6 of 7 checks passed
@marc2332 marc2332 deleted the feat/vertical-direction-for-slider branch September 28, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🔥 New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

enhancement: Vertical direction support for Slider
1 participant