Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support RootPercentage in calc() #907

Merged
merged 2 commits into from
Sep 28, 2024

Conversation

marc2332
Copy link
Owner

Closes #906

Copy link

Benchmark for cb43506

Click to view benchmark
Test Base PR %
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached 102.0±0.35ms 102.6±0.47ms +0.59%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached 23.7±0.91ms 24.3±1.28ms +2.53%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached 1384.8±13.78µs 1363.0±60.89µs -1.57%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached 132.1±3.06µs 131.8±2.06µs -0.23%
benchmarks/size=131071 depth=17 wide=2 mode=not cached 24.0±1.18ms 23.7±0.20ms -1.25%
benchmarks/size=16383 depth=14 wide=2 mode=not cached 1688.6±8.46µs 1684.4±37.52µs -0.25%
benchmarks/size=19531 depth=7 wide=5 mode=cached 318.4±5.38µs 318.0±14.62µs -0.13%
benchmarks/size=19531 depth=7 wide=5 mode=not cached 2.6±0.01ms 2.5±0.01ms -3.85%
benchmarks/size=4095 depth=12 wide=2 mode=not cached 413.3±147.43µs 414.1±117.32µs +0.19%
benchmarks/size=54241 depth=5 wide=15 mode=cached 249.7±12.78µs 253.5±10.01µs +1.52%
benchmarks/size=54241 depth=5 wide=15 mode=not cached 6.2±0.28ms 6.2±0.21ms 0.00%

@marc2332 marc2332 merged commit 31e42f5 into main Sep 28, 2024
5 checks passed
@marc2332 marc2332 deleted the feat/support-root-percentage-in-calc branch September 28, 2024 08:42
Copy link

Benchmark for 0c3be7e

Click to view benchmark
Test Base PR %
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached 104.7±0.16ms 103.8±1.26ms -0.86%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached 23.3±0.29ms 23.2±0.95ms -0.43%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached 1358.0±8.69µs 1366.8±46.30µs +0.65%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached 131.4±1.82µs 131.4±2.33µs 0.00%
benchmarks/size=131071 depth=17 wide=2 mode=not cached 23.2±0.24ms 23.0±0.12ms -0.86%
benchmarks/size=16383 depth=14 wide=2 mode=not cached 1699.6±75.16µs 1687.6±4.41µs -0.71%
benchmarks/size=19531 depth=7 wide=5 mode=cached 314.1±1.65µs 310.3±2.43µs -1.21%
benchmarks/size=19531 depth=7 wide=5 mode=not cached 2.8±0.01ms 2.5±0.01ms -10.71%
benchmarks/size=4095 depth=12 wide=2 mode=not cached 422.5±105.67µs 413.0±160.51µs -2.25%
benchmarks/size=54241 depth=5 wide=15 mode=cached 250.9±6.91µs 251.1±219.94µs +0.08%
benchmarks/size=54241 depth=5 wide=15 mode=not cached 6.2±0.09ms 6.2±0.03ms 0.00%

Copy link

codecov bot commented Sep 28, 2024

Codecov Report

Attention: Patch coverage is 98.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.02%. Comparing base (90f2bfb) to head (d6aedef).
Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
crates/torin/src/values/size.rs 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #907      +/-   ##
==========================================
- Coverage   76.06%   76.02%   -0.04%     
==========================================
  Files         207      207              
  Lines       23296    23393      +97     
==========================================
+ Hits        17719    17784      +65     
- Misses       5577     5609      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🔥 New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

enhancement: Support RootPercentage incalc()
1 participant