Rd 286: screenshots #107
Merged
Rd 286: screenshots #107
+103
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petrsloup
requested changes
Aug 26, 2024
There was a problem hiding this comment.
I think the use cases for wholePage option are quite limited and it's actually not that related to the maping SDK, requires extra permissions and is not entirely consistent cross-browser.
I'd prefer to have it removed and simplify the code significantly. (And also update the readme.)
Otherwise looks good (including the production/non-production build change).
petrsloup
approved these changes
Aug 29, 2024
readme.md
Outdated
| @@ -862,6 +862,37 @@ Turning off *zoom compensation* allows for more accurate adjustments to the visu | |||
|
|
|||
| All the other options are documented on [our reference page](https://docs.maptiler.com/sdk-js/api/helpers/#heatmap) and more examples are available [here](https://docs.maptiler.com/sdk-js/examples/?q=heatmap+helper). | |||
|
|
|||
| # Other helper | |||
| ## Take Screenshots, programmatically | |||
| There are two different ways to create sceenshot, corresponding to two very different usecases. Note that screenshots will not contain *DOM elements* such as `Marker` and `Popup`, since those are not part of the rendering context. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RD-286
The PR #106 must be merged first