Conflation project type osm ref #1051
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, reflect ref column in results temp in tests
Gigaszi
reviewed
Oct 22, 2025
mapswipe_workers/mapswipe_workers/firebase_to_postgres/transfer_results.py
Outdated
Show resolved
Hide resolved
Gigaszi
reviewed
Oct 22, 2025
mapswipe_workers/mapswipe_workers/generate_stats/project_stats.py
Outdated
Show resolved
Hide resolved
Gigaszi
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds OSM feature references to results and aggregated results of conflation projects.
The MapSwipe web app will write the number of intersecting OpenStreetMap features as reference to results in Firebase, and -- if this number is 1 -- the OSM type, id and version number.
With this PR, mapswipe workers will write the reference to results and to aggregated results.
Pre-requisite: Add ref column to mapping_session_results and results_temp tables in Postgres:
https://github.com/mapswipe/python-mapswipe-workers/blob/conflation-project-type-osm-ref/postgres/scripts/add_ref_to_results_for_conflation.sql