Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default font-face to Noto Sans Regular [#311] #436

Closed
wants to merge 1 commit into from
Closed

Change default font-face to Noto Sans Regular [#311] #436

wants to merge 1 commit into from

Conversation

bdon
Copy link

@bdon bdon commented Dec 4, 2023

  • Change it from Open Sans Regular, Arial Unicode MS Regular which does not have a freely licensed reproducible build.

See #311 for discussion.

I don't think that this change is high priority, I'd be fine with keeping the current defaults indefinitely. The consensus seems to be that this default should nearly never be used anyways.

Launch Checklist

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Link to related issues.
  • Document any changes to public APIs.
  • Add an entry to CHANGELOG.md under the ## main section.

* Change it from Open Sans Regular, Arial Unicode MS Regular which does not have a freely licensed reproducible build.
@HarelM
Copy link
Collaborator

HarelM commented Dec 4, 2023

I need to fix CI... sorry.
What about introducing the global default instead of this implicit default?

@bdon
Copy link
Author

bdon commented Dec 4, 2023

While I think that is a better solution, it introduce a new feature to the style, which I find undesirable, and can accomplish it using a preprocessor anyways.

@wipfli
Copy link
Contributor

wipfli commented Dec 5, 2023

Thanks @bdon for opening this pull request.

This looks like a breaking change in the style specification and I think breaking changes here should be avoided.

Maybe one day in the future we can make a "New MapLibre Style Spec" and have a bunch of breaking changes there, but until then I would say let's avoid breaking changes.

So I would say let's not merge this one...

@bdon
Copy link
Author

bdon commented Dec 5, 2023

OK, sounds good to me. Thanks for reviewing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants