-
-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebGL matrix performance fix #5072
Conversation
It would be nice to also have some hard perf numbers for this from a benchmark. I will see if there is a benchmark that can catch this and try to post some numbers tomorrow. |
Nice work and quick fix! |
Added a small question around object creation... |
Codecov is not running on PRs lately for somereason, I'll see if I can make it work again. |
…ix-fix # Conflicts: # src/geo/projection/globe_transform.ts # src/geo/projection/mercator_utils.ts # test/integration/render/tests/projection/globe/terrain/fill-planet-pole/expected-windows-flaky.png
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5072 +/- ##
==========================================
- Coverage 91.81% 91.80% -0.02%
==========================================
Files 279 279
Lines 38332 38340 +8
Branches 6698 6698
==========================================
+ Hits 35195 35197 +2
- Misses 3005 3009 +4
- Partials 132 134 +2 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
THANKS!
Fixes #5070 by passing float32 matrices to WebGL instead of float64. Note that the performance degradation only seemed to affect Chrome, not Firefox. Updates relevant unit & render tests.