Skip to content

Conversation

thanhdang198
Copy link
Contributor

@thanhdang198 thanhdang198 commented Feb 19, 2025

This pull request includes several changes to the Android project setup and dependencies, as well as some code refactoring in the GlobalMethodHandler class. The most important changes are grouped by theme and summarized below:

Android Project Setup:

Upgrade to latest Flutter Gradle plugins configuration:
https://docs.flutter.dev/release/breaking-changes/flutter-gradle-plugin-apply

Dependency Updates:

  • example/pubspec.yaml: Updated the path_provider dependency version from 2.0.15 to 2.1.5.
  • Set minimum supported Flutter version to 3.22.0

Code Refactoring:

@thanhdang198
Copy link
Contributor Author

Seems the GitHub action need to update to the latest flutter version.
https://github.com/maplibre/flutter-maplibre-gl/actions/runs/13409732268/job/37458089382?pr=542
Screenshot 2025-02-19 at 17 14 14

@josxha
Copy link
Collaborator

josxha commented Feb 19, 2025

@thanhdang198 feel free to increase the minimum Flutter and Dart version as needed.
The Static code analsis CI is failing, too. You can disable the deprecated_member_use lint for the maplibre_gl_web package to ignore the deprecations.

@josxha josxha linked an issue Feb 19, 2025 that may be closed by this pull request
@thanhdang198
Copy link
Contributor Author

@thanhdang198 feel free to increase the minimum Flutter and Dart version as needed. The Static code analsis CI is failing, too. You can disable the deprecated_member_use lint for the maplibre_gl_web package to ignore the deprecations.

I've increased the flutter version and ignore the deprecated in this commit.

@josxha josxha force-pushed the feat/flutter_3.29.0 branch from 239444e to 16b4bce Compare February 20, 2025 10:12
@josxha
Copy link
Collaborator

josxha commented Feb 20, 2025

Apologies, my last post wasn't very clear. What I meant was to bump the minimum required version of flutter in the pubspec.yaml files. The version in the CI should represent the lowest supported flutter version.

@thanhdang198
Copy link
Contributor Author

Apologies, my last post wasn't very clear. What I meant was to bump the minimum required version of flutter in the pubspec.yaml files. The version in the CI should represent the lowest supported flutter version.

Oh, sorry. And now should I update anything else in this PR?

Copy link
Collaborator

@josxha josxha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @thanhdang198!

@josxha josxha merged commit 909d5e6 into maplibre:main Feb 20, 2025
9 checks passed
@josxha
Copy link
Collaborator

josxha commented Feb 20, 2025

Oh, sorry. And now should I update anything else in this PR?

All good, thanks 😄

@thanhdang198
Copy link
Contributor Author

@josxha Thank for your support.

gabbopalma pushed a commit to gabbopalma/flutter-maplibre-gl that referenced this pull request Feb 20, 2025
This pull request includes several changes to the Android project setup
and dependencies, as well as some code refactoring in the
`GlobalMethodHandler` class. The most important changes are grouped by
theme and summarized below:

### Android Project Setup:
Upgrade to latest Flutter Gradle plugins configuration:

https://docs.flutter.dev/release/breaking-changes/flutter-gradle-plugin-apply
### Dependency Updates:

*
[`example/pubspec.yaml`](diffhunk://#diff-565b0869896732da3b937c64bc8fd5f0ca37ea1f629d579c29fc70e0f1e3e48eL20-R20):
Updated the `path_provider` dependency version from `2.0.15` to `2.1.5`.
* Set minimum supported Flutter version to 3.22.0

### Code Refactoring:

*
[`maplibre_gl/android/src/main/java/org/maplibre/maplibregl/GlobalMethodHandler.java`](diffhunk://#diff-9c836abc6c8048cf093a291198c86b17f16530e99328202318c54f9fe1c65c40L29-L37):
Removed the `registrar` field and related code, updating the constructor
and `openTilesDbFile` method to use `flutterAssets` instead.
[[1]](diffhunk://#diff-9c836abc6c8048cf093a291198c86b17f16530e99328202318c54f9fe1c65c40L29-L37)
[[2]](diffhunk://#diff-9c836abc6c8048cf093a291198c86b17f16530e99328202318c54f9fe1c65c40L155-R149)

---------

Co-authored-by: thanhdt-vietmap <[email protected]>
Co-authored-by: Joscha <[email protected]>
gabbopalma pushed a commit to gabbopalma/flutter-maplibre-gl that referenced this pull request Feb 20, 2025
This pull request includes several changes to the Android project setup
and dependencies, as well as some code refactoring in the
`GlobalMethodHandler` class. The most important changes are grouped by
theme and summarized below:

### Android Project Setup:
Upgrade to latest Flutter Gradle plugins configuration:

https://docs.flutter.dev/release/breaking-changes/flutter-gradle-plugin-apply
### Dependency Updates:

*
[`example/pubspec.yaml`](diffhunk://#diff-565b0869896732da3b937c64bc8fd5f0ca37ea1f629d579c29fc70e0f1e3e48eL20-R20):
Updated the `path_provider` dependency version from `2.0.15` to `2.1.5`.
* Set minimum supported Flutter version to 3.22.0

### Code Refactoring:

*
[`maplibre_gl/android/src/main/java/org/maplibre/maplibregl/GlobalMethodHandler.java`](diffhunk://#diff-9c836abc6c8048cf093a291198c86b17f16530e99328202318c54f9fe1c65c40L29-L37):
Removed the `registrar` field and related code, updating the constructor
and `openTilesDbFile` method to use `flutterAssets` instead.
[[1]](diffhunk://#diff-9c836abc6c8048cf093a291198c86b17f16530e99328202318c54f9fe1c65c40L29-L37)
[[2]](diffhunk://#diff-9c836abc6c8048cf093a291198c86b17f16530e99328202318c54f9fe1c65c40L155-R149)

---------

Co-authored-by: thanhdt-vietmap <[email protected]>
Co-authored-by: Joscha <[email protected]>
@kurmeroli
Copy link

Is a new version with this fix on the way to pub.dev?

@thanhdang198
Copy link
Contributor Author

Is a new version with this fix on the way to pub.dev?

@josxha Do you have permission to publish the package?

@josxha
Copy link
Collaborator

josxha commented Feb 21, 2025

Yes I'm able to publish to pub.dev but someone would have to prepare the release as I'm not able to merge my own pull requests. Or if another maintainer could do a review, that would work as well.

@smallTrogdor
Copy link
Contributor

smallTrogdor commented Feb 21, 2025

Yes I'm able to publish to pub.dev but someone would have to prepare the release as I'm not able to merge my own pull requests. Or if another maintainer could do a review, that would work as well.

What needs to be done in total?

@josxha
Copy link
Collaborator

josxha commented Feb 21, 2025

The next release would be 0.21.0. The v0.21.0 milestone has currently still some open tasks. Therefore

@smallTrogdor
Copy link
Contributor

The next release would be 0.21.0. The v0.21.0 milestone has currently still some open tasks. Therefore

I can start working on that tomorrow for some hours.

@smallTrogdor
Copy link
Contributor

See #543 #544 and #545 - thanks for making the release !

@kurmeroli
Copy link

Oh! Don’t feel stressed about my question. 🙈
No need to put in a huge effort right away. I’m just having a bit of trouble getting my project to run after updating Android Studio. I did pull the main branch into my pubspec.yml, but it still didn’t work.

@josxha josxha added this to the v0.21.0 milestone Feb 24, 2025
remax21 pushed a commit to viamichelin/flutter-maplibre-gl that referenced this pull request Feb 24, 2025
This pull request includes several changes to the Android project setup
and dependencies, as well as some code refactoring in the
`GlobalMethodHandler` class. The most important changes are grouped by
theme and summarized below:

### Android Project Setup:
Upgrade to latest Flutter Gradle plugins configuration:

https://docs.flutter.dev/release/breaking-changes/flutter-gradle-plugin-apply
### Dependency Updates:

*
[`example/pubspec.yaml`](diffhunk://#diff-565b0869896732da3b937c64bc8fd5f0ca37ea1f629d579c29fc70e0f1e3e48eL20-R20):
Updated the `path_provider` dependency version from `2.0.15` to `2.1.5`.
* Set minimum supported Flutter version to 3.22.0

### Code Refactoring:

*
[`maplibre_gl/android/src/main/java/org/maplibre/maplibregl/GlobalMethodHandler.java`](diffhunk://#diff-9c836abc6c8048cf093a291198c86b17f16530e99328202318c54f9fe1c65c40L29-L37):
Removed the `registrar` field and related code, updating the constructor
and `openTilesDbFile` method to use `flutterAssets` instead.
[[1]](diffhunk://#diff-9c836abc6c8048cf093a291198c86b17f16530e99328202318c54f9fe1c65c40L29-L37)
[[2]](diffhunk://#diff-9c836abc6c8048cf093a291198c86b17f16530e99328202318c54f9fe1c65c40L155-R149)

---------

Co-authored-by: thanhdt-vietmap <[email protected]>
Co-authored-by: Joscha <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Not compatible with flutter v3.29
5 participants