-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Feat process fit #331
Conversation
Added ability to use geotag directory for fit files
Feat process fit
… video. It returns a merged array of tuples from all sources
changed the gps parsers to be able to take lists rather than a single…
…odule since it's unrealiable with Synology server
@bob3bob3 I wasn't aware of that. I found this in the ffmpeg docs which is why I added the flag:
It may depend on |
@zlavergne qscale originally had no v argument I think as it also affected the audio stream. An ambiguity warning is given, but nothing adverse happens for us. I'd suggest keeping the :v argument. I also mis-spoke on my last. The flag(s) to ensure the value of 1 are -qmin 1 and -qmax 1. I mentioned this in #311 I don't suggest this be changed as the improvement is minimal for a large increase in file size. |
Examples; These are index frames taken from the BlackVue DR900 and processed with ffmpeg ffmpeg -i file.mp4 -vf "select=eq(pict_type,I)" -vsync vfr -qscale:v 1 2q/File_%6d.jpg ffmpeg -i file.mp4 -vf "select=eq(pict_type,I)" -vsync vfr -qscale:v 1 -qmin 1 -qmax 1 1q/File_%6d.jpg 720KBytes vs 1100KBytes. Does one look any better than the other? (Does github reprocess?) To avoid ambiguity qscale:v 2 might be used as it will give the same result as current. If qscale:v 1 is really desired then -qmin 1 -qmax 1 switches are required. |
Feat process fit
…ted `start` `camera_event`
… not the very first image
Feat process fit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* This occurs when dict entries do not match video names Signed-off-by: Taylor Smock <[email protected]>
Signed-off-by: Taylor Smock <[email protected]>
Signed-off-by: Taylor Smock <[email protected]>
Fix processing when video names do not match names in the fit file
Untested. I implemented the functions I had outside of the tools. Related to #327
cc @josealb