Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the feature details/edit modal UI to use tabbed sections (Details/Properties/Style/Advanced) and adjusts related JS/CSS and feature specs accordingly.
Changes:
- Reworked feature modal header + edit controls into tab-style navigation and sectional edit UI (properties/style/advanced).
- Updated Stimulus controllers + maplibre feature detail rendering to support the new tab behavior.
- Adjusted feature/system specs and modal styling to match new UI labels and interactions.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| spec/support/feature_helpers.rb | Changes screenshot output directory path. |
| spec/features/map_layers_spec.rb | Updates expected UI text from the modal ("Edit feature" → "Properties"). |
| spec/features/feature_edit_spec.rb | Updates selectors/click flows to use new tab buttons and new title/label behavior. |
| spec/features/feature_details_spec.rb | Uses private map path and improves modal resize assertion. |
| app/views/maps/modals/feature/_edit_ui.haml | Introduces edit sections (properties/style/advanced) and reorganizes edit UI. |
| app/views/maps/modals/feature/_edit_raw.haml | Adjusts raw JSON editor visibility/spacing. |
| app/views/maps/modals/_feature.haml | Replaces button group with tab buttons and tweaks header/meta layout. |
| app/javascript/maplibre/feature.js | Updates details view to mark “Details” tab active and hide edit UI. |
| app/javascript/controllers/feature/modal_controller.js | Implements tab switching logic and advanced-tab raw JSON initialization. |
| app/javascript/controllers/feature/edit_controller.js | Replaces label editing with “Show title on map” toggle logic. |
| app/assets/stylesheets/modals.css | Tweaks pull-button positioning on small screens. |
| app/assets/stylesheets/feature.css | Redesigns modal look and adds styles for tabs/sections/cards. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Pull Request Test Coverage Report for Build 22678949708Details
💛 - Coveralls |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.