Annotation tap and long press events #977
Merged
+906
−670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jun 25, 2025
evil159
reviewed
Jun 25, 2025
maios
changed the title
pjleonard37
reviewed
Jun 25, 2025
| onAnnotationClick: (annotation) => circleAnnotation = annotation, | ||
| ), | ||
| ); | ||
| circleAnnotationManager?.tapEvents(onTap: (annotation) { |
There was a problem hiding this comment.
I think we can now remove the AnnotationClickListener class from this example (and the other examples). It would be good to do this so devs are not confused.
pjleonard37
requested changes
Jun 25, 2025
| @@ -1,6 +1,22 @@ | |||
| ### main | |||
|
|
|||
| * Introduce new experimental properties: `FillLayer.fillConstructBridgeGuardRail`, `FillLayer.fillBridgeGuardRailColor`, `FillLayer.fillTunnelStructureColor`, `CircleLayer.circleElevationReference`. | |||
| * Introduce `tapEvents` and `longPressEvents` API to the Annotation Managers to handle tap and long press event callbacks for annotations: | |||
There was a problem hiding this comment.
Can we mention the deprecation here as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
This PR adds
tapEventsandlongPressEventsto Annotations API, allowing users to provide a callback to be invoked and an annotation is tapped or long pressed.Both API will return a Cancelable token, which can be used to stop listening to interaction events.
With
tapEvents, we are now aligning with platform implementation that use IME underlying, instead of using old API in iOS and observe interaction events via delegation, and since the tap interaction is now not propagated to the annotation below the topmost one, you will get exactly one callback when you tap on overlapping annotations as described in #791What is the motivation and context behind this change?
Pull request checklist:
PRs must be submitted under the terms of our Contributor License Agreement CLA.