Apply suggestions from code review

Co-authored-by: Volodymyr Agafonkin <[email protected]>
mapbox · Oct 31, 2023 · e0b0e8e · e0b0e8e
1 parent 2c968b8
commit e0b0e8e
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/src/render/program/line_program.js b/src/render/program/line_program.js
@@ -93,7 +93,7 @@ const lineUniformValues = (
         'u_dash_image': 0,
         'u_gradient_image': 1,
         'u_image_height': imageHeight,
-        'u_texsize': hasDash(layer) ? (tile.lineAtlasTexture ? tile.lineAtlasTexture.size : [0, 0]) : [0, 0],
+        'u_texsize': hasDash(layer) && tile.lineAtlasTexture ? tile.lineAtlasTexture.size : [0, 0],
         'u_tile_units_to_pixels': calculateTileRatio(tile, painter.transform),
         'u_alpha_discard_threshold': 0.0,
         'u_trim_offset': trimOffset,

diff --git a/src/terrain/draw_terrain_raster.js b/src/terrain/draw_terrain_raster.js
@@ -336,8 +336,6 @@ function drawTerrainRaster(painter: Painter, terrain: Terrain, sourceCache: Sour
                 // Bind the main draped texture
                 context.activeTexture.set(gl.TEXTURE0);
                 if (tile.texture) {
-                    // This call seemed invalid with 3 args?
-                    // tile.texture.bind(gl.LINEAR, gl.CLAMP_TO_EDGE, gl.LINEAR_MIPMAP_NEAREST);
                     tile.texture.bind(gl.LINEAR, gl.CLAMP_TO_EDGE);
                 }