extract geometrycollection geometries to features #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add geometrycollection condition: extract geometrycollection geometries to features.
change arrow function to es5
|
Hey @tmcw, what do you think about this PR? Thanks for your help! <3 |
|
I don't work at Mapbox anymore so can't review or merge PRs. This one, though - I don't think this is the correct behavior. The purpose of geojson-normalize is to normalize features and bare geometries to FeatureCollections. For it to split GeometryCollections would be incorrect. See geojson-flatten for a utility to flatten multi features. |
|
Sounds great, thanks for letting me know dude! <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add geometrycollection condition:
extract geometrycollection geometries to features.
sorry about with vscode prettier format.