feat: add simple tasks and config files #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k4black
changed the title
* build base docker * push to ghrc.io * run checker in it
due not available in inputs
k4black
force-pushed
the
new-project-structure
branch
from
f1f68a1 to
88422ae
Compare
kalabukdima
reviewed
Nov 9, 2023
.checker.yml
Outdated
Comment on lines
7
to
9
| private_patterns: ["**/.*", "**/test_private.py"] | ||
| # public patterns to export | ||
| public_patterns: ["tools", "pyproject.toml", ".gitignore", "**/test_public.py", "**/conftest.py"] |
There was a problem hiding this comment.
It's not clear what happens to files matching both (or none) patterns. Maybe we should use some regex supporting negative lookahead and merge it into a single list?
| script: "python -m mypy --config-file=${{ REPO_DIR }}/pyproject.toml ${{ TASK_DIR }}" | ||
|
|
||
| - name: "Collect tests" | ||
| run_if: ${{ run_testing }} |
There was a problem hiding this comment.
Maybe those should be nested in some object, like {{ task.run_testing }}?
There was a problem hiding this comment.
Seems it is more complicated to do - you need an real objects there e.g. jinja2
| script: "python -m pytest --tb=no -qq --collect-only ${{ TASK_DIR }}" | ||
| timeout: ${{ timeout }} | ||
|
|
||
| - name: "Run tests" |
There was a problem hiding this comment.
For the grading one possible solution would be to assign a weight for each step in the pipeline and use the weighted sum of passed steps as the score. That way you can customize what is making up the score but it still doesn't solve the case with multiple grade types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The new structure for the course repository under consideration.
.task.ymlfileMotivation and Context
The old structure is outdated, a lot of small deprecated things, some issues not solvable with it, so new.
Please see the main project for the plan.
Related to
Contribution Checklist
General
tag(scope): description.Added tests?
Added to documentation?
docs/manytask.github.iopageWhat gif best describes this PR or how it makes you feel?