Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

req: replace * with range #188

Merged
merged 2 commits into from
May 6, 2023

Conversation

Borda
Copy link
Collaborator

@Borda Borda commented May 5, 2023

this shall simplify work of pip resolver

closes #177


📚 Documentation preview 📚: https://pytorch-tabular--188.org.readthedocs.build/en/188/

@Borda
Copy link
Collaborator Author

Borda commented May 5, 2023

@manujosephv this shall be a safe change 🐿️

@Borda
Copy link
Collaborator Author

Borda commented May 5, 2023

it is needed to work correctly with other packages and it is tested with Flash, see Lightning-Universe/lightning-flash#1545

requirements.txt Outdated Show resolved Hide resolved
@manujosephv manujosephv merged commit da434ea into manujosephv:main May 6, 2023
@manujosephv
Copy link
Owner

manujosephv commented May 6, 2023

merged! but requirements_extra.txt also has the issue..

@Borda Borda deleted the req/replace branch May 6, 2023 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants