Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support logic signatures #22

Merged
merged 4 commits into from
May 28, 2021
Merged

Support logic signatures #22

merged 4 commits into from
May 28, 2021

Conversation

ivnsch
Copy link
Contributor

@ivnsch ivnsch commented May 22, 2021 •
edited
Loading

Closes #21

ivnsch
ivnsch commented May 24, 2021
View reviewed changes
algonaut_transaction/src/account.rs
multisig: None,
transaction_id: id,
})
}

pub fn sign_logic_msig(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like these functions (+append_to_logic_msig) that much, for now ported from the official SDKs. See #23

@ivnsch ivnsch mentioned this pull request May 24, 2021
Closed
@ivnsch ivnsch marked this pull request as ready for review May 25, 2021 08:02
@ivnsch
Copy link
Contributor Author

ivnsch commented May 25, 2021 •
edited
Loading

Only integrations tests. I created new issues for the Unit Tests (#24) and smart contract verification (#25). The Unit Tests depend on #28.

@manuelmauro
Copy link
Owner

Cool to see this working!

@manuelmauro manuelmauro merged commit 1af3a23 into manuelmauro:main May 28, 2021
@ivnsch ivnsch deleted the support_logic_sig branch May 31, 2021 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Is there a way to create a LogicSig?
2 participants
@ivnsch @manuelmauro