Atomic Transaction Composer #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivnsch
force-pushed
the
atomic-tx-composer
branch
from
cd5878f
to
9827910
Compare
|
#1 ABI and C2C features implemented |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported from the latest official SDKs (Go v1.14.1 and Java 1.13.0 - had to alternate between both a bit). Ported all the related unit and integration/cucumber tests (ABI and C2C features). Did refactorings (also in #154) especially at high level, to make things more idiomatic for Rust, prevent type casting, split large functions etc. It can be improved more, but I'm already way over the time allocated for this.
Closes #150