add redis ping #53
Merged
add redis ping #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
run command `pre-commit run -a` instead of just isort
alex-nork
commented
Jul 10, 2023
zimventures
suggested changes
Jul 11, 2023
Comment on lines
72
to
74
| alert('Ping successful'); | ||
| } else { | ||
| alert('Ping failed: ' + (result.error || 'Unknown error')); |
There was a problem hiding this comment.
Instead of using alerts, let's class it up and use Bootstrap's toaster notifications!
There was a problem hiding this comment.
Hell yeah! Nice work 👍👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slightly easier to review with whitespace changes hidden
Files changed
The purpose of this PR is to add a
Pingbutton to redis targets which allows a user to test the connection to their redis instance.Successful connection:
Unsuccessful connection:
