Added match to header jwk evaluate_for predicate impl #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Thank you for the nice manas crate.
I added a match expression to check against the underlying Jwk type from picky::jose::jwk crate.
All of the supported types by the picky crate automatically have the JwkPublicKey type, so private key fields for ED, ECC, and RSA should not be exposed. If there is a better way to check these or if there is a need to further check, then I will make the suggsted changes.
For `the ``oct``` type, it is required by RFC, but the picky::jose::jwk crate does not support it. Is there anything I can or should do to make this work, or is that a limitation of the underlying library?