libassuan socket emulation file support #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds new `process_sock_file()` function which takes the path of the libassuan "socket" and parses out the port number and cookie for the real socket connection.
Seems that sending the cookie might not be enough to establish the connection, as things get stuck after this with no messages one way or the other. Calling out that we need to investigate how to complete any handshake for libassuan's AF_UNIX emulation before we can continue communicating between the pipe and socket.
Write to stdout whenever anything happens so we can follow along.
Also make nonzero check explicit for `debug_mode` in the macro to ensure that messages _will_ be printed when the debug flag is used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes care of processing the socket file to get the port and cookie, but even so the program still gets stuck sending the cookie across. With gpg-agent and uds-2-np running, and three attempts to do
ssh-add -l(cancelled after 30s via Ctrl+C each time):After looking into code for both gpg-agent and libassuan, it doesn't look like we need to send anything other than the cookie, and it doesn't look like we need to receive or acknowledge anything sent back before ssh-agent protocol can be used on the connection.