Skip to content

Commit

Permalink
Merge branch 'develop' into conclusion-logger
Browse files Browse the repository at this point in the history
  • Loading branch information
manas-yu authored Nov 13, 2024
2 parents 4383b49 + 3dc9561 commit 8b04bae
Show file tree
Hide file tree
Showing 7 changed files with 4 additions and 28 deletions.
4 changes: 0 additions & 4 deletions .github/workflows/build_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,6 @@ name: Build Tests
on:
workflow_dispatch:
pull_request:
push:
branches:
# Push events on develop branch
- develop

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.run_id }}
Expand Down
4 changes: 0 additions & 4 deletions .github/workflows/code_coverage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,6 @@ name: Code Coverage
# events or push events in the develop branch.
on:
pull_request:
push:
branches:
# Push events on develop branch
- develop

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.run_id }}
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/comment_coverage_report.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,11 @@ jobs:
permissions:
pull-requests: write

# The expression if: ${{ !cancelled() && needs.check_code_coverage_completed.outputs.conclusion != 'action_required' }}
# ensures that this job only runs if the previous job was not cancelled and does not require manual approval.
# The expression if: ${{ !cancelled() && needs.check_code_coverage_completed.outputs.conclusion != 'action_required' }}
# ensures that this job only runs if the previous job was not cancelled and does not require manual approval.
# This check prevents running the job unnecessarily when a manual approval is needed.
if: |
!cancelled() &&
!cancelled() &&
needs.check_code_coverage_completed.outputs.conclusion != 'action_required'
runs-on: ubuntu-latest
steps:
Expand Down Expand Up @@ -88,4 +88,4 @@ jobs:
uses: peter-evans/create-or-update-comment@v4
with:
issue-number: ${{ github.event.pull_request.number }}
body-path: 'CoverageReport.md'
body-path: 'CoverageReport.md'
4 changes: 0 additions & 4 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,6 @@ name: Unit Tests (Robolectric -- Gradle)
on:
workflow_dispatch:
pull_request:
push:
branches:
# Push events on develop branch
- develop

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.run_id }}
Expand Down
4 changes: 0 additions & 4 deletions .github/workflows/static_checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,6 @@ name: Static Checks

on:
workflow_dispatch:
pull_request:
push:
branches:
- develop

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.run_id }}
Expand Down
5 changes: 0 additions & 5 deletions .github/workflows/unit_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,6 @@ name: Unit Tests (Robolectric - Bazel)
# events or push events in the develop branch.
on:
workflow_dispatch:
pull_request:
push:
branches:
# Push events on develop branch
- develop

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.run_id }}
Expand Down
3 changes: 0 additions & 3 deletions .github/workflows/wiki.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,6 @@ on:
pull_request:
paths:
- 'wiki/**'
push:
branches:
- develop
paths:
- 'wiki/**'
# Triggers this workflow when the wiki is changed.
Expand Down

0 comments on commit 8b04bae

Please sign in to comment.