Fix async/await: Remove unnecessary Task.Run usage in document converters #17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Multiple document converters were using
Task.Runto wrap synchronous operations in async methods, which is an anti-pattern that wastes resources by unnecessarily switching threads without any benefit. This pattern only makes sense for GUI applications where you need to keep the UI thread responsive, but not for library code.Examples of the problematic pattern:
Changes Made
Fixed 5 instances of unnecessary
Task.Runusage across 4 converter files:PdfConverter.cs (2 fixes):
PdfPigTextExtractor.ExtractTextAsync: PDF text extractionRenderOnSupportedPlatformsAsync: PDF image renderingDocxConverter.cs:
ExtractTextFromDocxAsync- Word document processingXlsxConverter.cs:
ExtractDataFromXlsxAsync- Excel spreadsheet processingPptxConverter.cs:
ExtractContentFromPptxAsync- PowerPoint presentation processingBenefits
The fix follows .NET async best practices by avoiding
Task.Runin library code where it provides no benefit, while maintaining proper cancellation token support and async method signatures.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
ccsca2021.crl.certum.pldotnet build MarkItDown.slnx(dns block)ccsca2021.ocsp-certum.comdotnet build MarkItDown.slnx(dns block)crl.certum.pldotnet build MarkItDown.slnx(dns block)subca.crl.certum.pldotnet build MarkItDown.slnx(dns block)subca.ocsp-certum.comdotnet build MarkItDown.slnx(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.