Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup readme #4

Merged
merged 1 commit into from
Sep 14, 2023
Merged

cleanup readme #4

merged 1 commit into from
Sep 14, 2023

Conversation

Refaerds
Copy link
Contributor

No description provided.

tomkln
tomkln approved these changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@tomkln tomkln left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, are we no longer using tagFiringOptions?

// Edit: Seems like we're removing it :)

@Refaerds
Copy link
Contributor Author

Out of curiosity, are we no longer using tagFiringOptions?

// Edit: Seems like we're removing it :)

it's not used either by Zaraz FPW or the MC, so yes, we're removing it

@Refaerds Refaerds merged commit 54d4475 into main Sep 14, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomkln tomkln tomkln approved these changes

@bjesus bjesus Awaiting requested review from bjesus

@simonabadoiu simonabadoiu Awaiting requested review from simonabadoiu

@kuba-orlik kuba-orlik Awaiting requested review from kuba-orlik

@jonnyparris jonnyparris Awaiting requested review from jonnyparris

@omarmosid omarmosid Awaiting requested review from omarmosid

@ad-astra-via ad-astra-via Awaiting requested review from ad-astra-via

Assignees

@Refaerds Refaerds

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Refaerds @tomkln