Additions for compiling plymouth #1312
Conversation
|
Fixed comments + provided a test for rpmatch. |
| return 0; | ||
| if(resp[0] == 'y' || resp[0] == 'Y') | ||
| return 1; | ||
| if(resp[0] == 'n' || resp[0] == 'N') |
There was a problem hiding this comment.
rpmatch shouldn't really accept something like yno and interpret it as yes... so these checks should probably be inlined with the prior strcasecmps. eg:
if(!strcasecmp("yes", resp) || !strcasecmp("y", resp))
There was a problem hiding this comment.
It should, and the man page specifically mentions this.
There was a problem hiding this comment.
Where does it say that? Because i can't find it.
There was a problem hiding this comment.
afaict it just says you have to match ^[Yy] and ^[Nn] regardless of language, not ^[Yy].* or ^[Nn].*
There was a problem hiding this comment.
^[Yy] and ^[Nn] don't match whole strings, they match anything that starts with Y/y/N/n.
There was a problem hiding this comment.
okay, that being the case I think this is stupid behaviour that we should not be emulating
|
Updated to apply fixes. |
No description provided.