Skip to content

tests/rtld: new search-order test#1273

Merged
Dennisbonke merged 4 commits intomanagarm:masterfrom
lzcunt:rtld-search-order-tests
Jul 3, 2025
Merged

tests/rtld: new search-order test#1273
Dennisbonke merged 4 commits intomanagarm:masterfrom
lzcunt:rtld-search-order-tests

Conversation

@lzcunt
Copy link
Copy Markdown
Contributor

@lzcunt lzcunt commented Feb 26, 2025

Adds a new test for the search order behavior fixed in #1238.

lzcunt added 2 commits June 25, 2025 23:50
This allows test subdirs in tests/rtld to conditionally skip, e.g. when
patchelf is needed to build a test and not found.
Meson will only append environment variables and not overwrite them,
which makes a couple rtld tests (search-order and ld_library_path)
erroneously pass because meson passes a LD_LIBRARY_PATH environment
variable.

This patch wraps rtld tests with a new `env.py` script to overwrite
environment variables instead of appending them.
@lzcunt lzcunt force-pushed the rtld-search-order-tests branch from df8a2fd to 45a9181 Compare June 28, 2025 14:15
@lzcunt lzcunt marked this pull request as ready for review June 28, 2025 14:15
@lzcunt lzcunt force-pushed the rtld-search-order-tests branch from 45a9181 to 1000bef Compare June 28, 2025 14:47
lzcunt added 2 commits June 28, 2025 18:04
The recently added rtld/search-order test only runs when patchelf is
found, otherwise is skipped.
@lzcunt lzcunt force-pushed the rtld-search-order-tests branch from 1000bef to ba99bf3 Compare June 28, 2025 15:04
Copy link
Copy Markdown
Member

@Dennisbonke Dennisbonke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@no92 no92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dennisbonke Dennisbonke added this pull request to the merge queue Jul 3, 2025
Merged via the queue into managarm:master with commit 5844356 Jul 3, 2025
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants