rtld: Use breadth-first search order #1238
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows test subdirs in tests/rtld to conditionally skip, e.g. when patchelf is needed to build a test and not found.
lzcunt
force-pushed
the
rtld-search-order
branch
2 times, most recently
from
c45b435 to
c52988c
Compare
lzcunt
force-pushed
the
rtld-search-order
branch
from
c52988c to
73c8f83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP I haven't actually implemented the fix yet just working on making a simple test that reproduces the issue.
Related to #1196, might fix the systemd issue but doesn't actually implement RPATH inheritance, simply makes RTLD search breadth-first. Will fix the
libgcc_s.so.1issue in nixpkgs. Adds a test for verifying the search order however that test currently erroneously passes when it should fail because of issues with meson. Running it outside of meson (and manually patchelf'ing to remove the RUNPATH in libbar) reproduces the issue (libfoo is not found in mlibc, correctly found in glibc).