various fixes for failing GMP tests #1236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the failing GMP tests documented in managarm#1221.
This patch adds a simple test for ftell's functionality which also acts as a simple reproducible test case for the failing GMP tests documented in managarm#1221. This test used to fail because our behaviour when checking ftell after a ungetc didn't match glibc.
Also adds DECIMAL_POINT and THOUSAND_SEP which seem to be aliases originating from glibc.
lzcunt
changed the title
|
All GMP tests pass when GMP is patched with this tiny patch. --- a/tests/cxx/clocale.c
+++ b/tests/cxx/clocale.c
@@ -41,7 +41,7 @@ the GNU MP Library test suite. If not, see https://www.gnu.org/licenses/. */
extern char point_string[];
-#if HAVE_LOCALECONV && ! defined __MINGW32__
+#if HAVE_LOCALECONV && ! defined __MINGW32__ && 0
struct lconv *
localeconv (void)
#if defined __cplusplus && defined __GLIBC__
@@ -54,7 +54,7 @@ localeconv (void)
}
#endif
-#if HAVE_NL_LANGINFO
+#if HAVE_NL_LANGINFO && 0
char *
nl_langinfo (nl_item n)
#if defined __cplusplus && defined __GLIBC__ |
no92
reviewed
Feb 5, 2025
Also adds a test for fputs.
mintsuki
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ftell behaviour after ungetc, and adds a simple test for ftell's functionality which also acts as a simple reproducible test case for the failing GMP tests documented in #1221. This test used to fail because our behaviour when checking ftell after a ungetc didn't match glibc.
Adds support for RADIXCHAR and THOUSEP in nl_langinfo, and adds some glibc aliases (not sure if they should be gated or available for all posix targets)
Fixes empty string handling in fputs and adds a simple test for fputs.
Fixes #1221.