Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wireshark dissector support #7

Merged
merged 7 commits into from
Mar 9, 2025
Merged

Conversation

no92
Copy link
Member

@no92 no92 commented Jan 28, 2025

No description provided.

@no92 no92 force-pushed the wireshark branch 4 times, most recently from 0cdb17d to c2814f9 Compare February 5, 2025 19:54
Copy link
Member

@qookei qookei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me, although I don't really know how Wireshark dissectors work so I'll trust you on that one :^) I do agree that format should probably be renamed to not take away a type name.

Copy link
Member

@Dennisbonke Dennisbonke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@no92 no92 marked this pull request as ready for review March 9, 2025 00:59
@avdgrinten avdgrinten merged commit 97b72d3 into managarm:master Mar 9, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants