Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AArch64 build #388

Merged
merged 9 commits into from
Oct 30, 2024
Merged

Fix AArch64 build #388

merged 9 commits into from
Oct 30, 2024

Conversation

qookei
Copy link
Member

@qookei qookei commented Oct 30, 2024

Mainly just disabling gobject-introspection on AArch64 via y4.

Doing this is necessary for site_architectures to be computed
correctly, since packages without it default to x86_64, which leads to
noarch packages being installed for x86_64 instead of aarch64.
host-limine now requires that the build machine has clang installed
with support for x86_64 and aarch64.

The limine package now toggles between all the x86_64 flags and
aarch64 flags depending on architecture. Ideally we'd just use
host-llvm-toolchain for it as well, but we don't build lld yet.
Copy link
Member

@Dennisbonke Dennisbonke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, but I have a few style issues.

bootstrap.d/app-accessibility.y4.yml Outdated Show resolved Hide resolved
bootstrap.d/app-accessibility.y4.yml Outdated Show resolved Hide resolved
bootstrap.d/app-accessibility.y4.yml Outdated Show resolved Hide resolved
bootstrap.d/app-crypt.y4.yml Outdated Show resolved Hide resolved
bootstrap.d/app-crypt.y4.yml Outdated Show resolved Hide resolved
bootstrap.d/x11-libs.y4.yml Outdated Show resolved Hide resolved
bootstrap.d/x11-libs.y4.yml Outdated Show resolved Hide resolved
bootstrap.d/x11-libs.y4.yml Show resolved Hide resolved
bootstrap.d/x11-libs.y4.yml Outdated Show resolved Hide resolved
bootstrap.d/x11-libs.y4.yml Outdated Show resolved Hide resolved
Copy link
Member

@Dennisbonke Dennisbonke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dennisbonke Dennisbonke merged commit 01f8e9c into managarm:master Oct 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants