Merge pull request juju#18273 from jack-w-shaw/JUJU-6718_remove_ports…

…_mongo

juju#18273

Stop dual-writing ports data to Mongo now that all read sites have been transitioned over to DQLite.

This means the Mongo ports collection is now unused. Remove the collection, and all the code to manipulate ports in Mongo

Remove some unused mocks from certain facades

## QA steps

Juju compiles

#### IAAS

```
$ juju bootstrap aws aws
$ juju add-model m
$ juju deploy ubuntu
$ juju expose ubuntu
$ juju exec --unit ubuntu/0 open-port 1000/tcp
$ juju exec --unit ubuntu/0 opened-ports
1000/tcp
```
& verify in aws 1000/tcp has been opened for the unit

#### CAAS

(remember to run `make microk8s-operator-upgrade`)

```
$ juju bootstrap microk8s mk8s
$ juju add-model m
$ juju deploy hello-kubecon
$ juju exec --unit hello-kubecon/0 open-port 1000/tcp
$ juju exec --unit hello-kubecon/0 opened-ports
1000/tcp
```
& verify in microk8s port 1000/tcp has been opened for the unit

apiserver/common/firewall/state.go

@@ -86,7 +86,6 @@ func (st stateShim) Unit(name string) (Unit, error) {
 type Machine interface {
 	Id() string
 	WatchAddresses() state.NotifyWatcher
-	OpenedPortRanges() (state.MachinePortRanges, error)
 	IsManual() (bool, error)
 }
 

apiserver/facades/agent/uniter/uniter.go

@@ -2602,11 +2602,6 @@ func (u *UniterAPI) commitHookChangesForOneUnit(ctx context.Context, unitTag nam
 	}
 
 	if len(changes.OpenPorts)+len(changes.ClosePorts) > 0 {
-		pcp, err := unit.OpenedPortRanges()
-		if err != nil {
-			return errors.Trace(err)
-		}
-
 		openPorts := network.GroupedPortRanges{}
 		for _, r := range changes.OpenPorts {
 			// Ensure the tag in the port open request matches the root unit name
@@ -2625,7 +2620,6 @@ func (u *UniterAPI) commitHookChangesForOneUnit(ctx context.Context, unitTag nam
 				Protocol: r.Protocol,
 			}
 			openPorts[r.Endpoint] = append(openPorts[r.Endpoint], portRange)
-			pcp.Open(r.Endpoint, portRange)
 		}
 
 		closePorts := network.GroupedPortRanges{}
@@ -2641,9 +2635,7 @@ func (u *UniterAPI) commitHookChangesForOneUnit(ctx context.Context, unitTag nam
 				Protocol: r.Protocol,
 			}
 			closePorts[r.Endpoint] = append(closePorts[r.Endpoint], portRange)
-			pcp.Close(r.Endpoint, portRange)
 		}
-		modelOps = append(modelOps, pcp.Changes())
 
 		unitUUID, err := u.applicationService.GetUnitUUID(ctx, unitTag.Id())
 		if err != nil {