refactor: abstraction for features #558

yudukikun5120 · 2022-12-17T16:24:23Z

This PR enables TSC to detect missing implementation for features and relates to #505 in bringing easiness for listing features.

src/network/storage.ts

mkobayashime

Thanks a lot!
My apologies for the conflict after #505, I'll approve this as soon as it's resolved.

src/options.ts

yudukikun5120 · 2023-01-09T15:22:29Z

@mkobayashime
I regret to say that the commitlint error caused by the commit 67ecf52 can be ignored since the introduction of commitlint follows chronologically the commit.

mkobayashime · 2023-01-10T13:31:11Z

@yudukikun5120
I think what commitlint is asking for is not to use uppercased character (T in the TSC in this case) at the beginning of the subject. chore: tsc can detect... will do for instance.

mkobayashime · 2023-01-10T13:35:58Z

src/types/feature.ts

+
+type Feature = (typeof Feature)[number]
+
+const isFeature = (key: string): key is Feature => key in Feature


I'm afraid in operator doesn't work as expected here as documented in MDN. It should be Array.prototype.includes instead.

Thank you for your suggestion, but I'd use the find method instead since I somehow came across the TSC error.

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

according to: selector-class-pattern

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore: issue template for feature proposal * fix: remove checkboxes * chore: alternatives are not required

…ct layer

…om ESLint to Lint

src/optionsPage/app.tsx

src/optionsPage/components/Header/index.tsx

src/optionsPage/app.tsx

codeclimate · 2023-01-10T15:48:14Z

Code Climate has analyzed commit 7f51635 and detected 0 issues on this pull request.

View more on Code Climate.

yudukikun5120 · 2023-01-10T15:53:13Z

@mkobayashime It is too hard to modify the past commit messages. I think we should skip the commitlint errors in this PR.

chore: function setStorage can take generic type

2438c68

codeclimate bot reviewed Dec 18, 2022

View reviewed changes

src/network/storage.ts Outdated Show resolved Hide resolved

src/network/storage.ts Outdated Show resolved Hide resolved

yudukikun5120 marked this pull request as ready for review December 18, 2022 09:54

yudukikun5120 requested a review from mkobayashime as a code owner December 18, 2022 09:54

yudukikun5120 enabled auto-merge (squash) December 18, 2022 10:05

yudukikun5120 mentioned this pull request Dec 21, 2022

feat: display unsubmitted assignments on the manaba home page #561

Draft

mkobayashime reviewed Jan 7, 2023

View reviewed changes

yudukikun5120 commented Jan 8, 2023

View reviewed changes

src/options.ts Outdated Show resolved Hide resolved

yudukikun5120 disabled auto-merge January 9, 2023 14:57

yudukikun5120 enabled auto-merge (squash) January 9, 2023 15:13

mkobayashime suggested changes Jan 10, 2023

View reviewed changes

yudukikun5120 and others added 17 commits January 11, 2023 00:32

chore: tsc can detect missing impls for a feature

ea5bc5d

fix: separate with type argument

ceb2431

fix: linted by Code Climate

cae2eb4

fix: use Extract utility type as kind

0beff8f

docs: add lang attribute to the html node (#562)

9177f88

Update typescript-eslint monorepo to v5.47.0 (#559)

e2eace5

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Add React related packages

4b64154

TypeScript config for React

583093c

Webpack config for React

2bcec65

Introduce React in options page minimally

b7c61aa

Ensure CSS Modules work

4e96451

Implement <Notice /> component

8d655d9

Use <Notice /> in the options page

f661431

chore: let Renovate to group patch upgrades

9df6a9f

chore: enable semantic commits by Renovate

a70ef16

chore(deps): pin dependencies

e336e6a

chore(deps): update patch upgrades

83e34b7

mkobayashime and others added 24 commits January 11, 2023 00:33

refactor(options): move <Notice /> to outside the <header />

8ba83bc

refactor(options): rewrite the header as a React component

4b63c8b

refactor(options): rewrite styles in component specific CSS Module

0dcfc94

chore: refine vertical spacing

80e3dcf

refactor: show version number in the React way

9f510d5

style: kebabcased manabaOriginalButton

c3774ec

according to: selector-class-pattern

chore(deps): update dependency eslint to v8.31.0 (#571)

5d695bc

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

chore: show yudukikun5120 as a maintainer

6634530

feat(style): line distro sections in a row (#581)

0a09ab8

chore(deps): update dependency eslint-config-prettier to v8.6.0 (#579)

9dad87d

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

chore(deps): update typescript-eslint monorepo to v5.48.0 (#580)

4e34ee1

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

chore(deps): update commitlint monorepo to v17.4.0

6bfb599

chore: issue template for feature proposals (#511)

3c45959

* chore: issue template for feature proposal * fix: remove checkboxes * chore: alternatives are not required

chore(deps): update patch upgrades

992d45e

style: run Prettier

331c208

refactor: handle click event of the link to the shortcuts page on Rea…

c7b8835

…ct layer

refactor: re-implement release note in options page as a React component

d095b19

ci: rename the name of lint step which includes Stylelint actually fr…

471e01a

…om ESLint to Lint

chore: add maintainers and contributors to package.json (#585)

ab7cf34

refactor: rewrite ReportGenerateRow in React way

ddd14a1

refactor: rename to appendReportGeneratorRow

8ec74c5

refactor: complexity of the function colorizeDeadline (#557)

ad1a48a

refactor: dom.id is guarded with isFeature

81f3aca

fix: isFeature uses the find method

111d61f

yudukikun5120 force-pushed the refactor/abstract-features branch from 4f23a05 to 111d61f Compare January 10, 2023 15:35

codeclimate bot reviewed Jan 10, 2023

View reviewed changes

yudukikun5120 added 2 commits January 11, 2023 00:42

Merge branch 'main' into refactor/abstract-features

7ed0b7d

ci: empty commit

7f51635

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: abstraction for features #558

refactor: abstraction for features #558

yudukikun5120 commented Dec 17, 2022 •

edited

Loading

mkobayashime left a comment

yudukikun5120 commented Jan 9, 2023

mkobayashime commented Jan 10, 2023

mkobayashime Jan 10, 2023

yudukikun5120 Jan 10, 2023

codeclimate bot commented Jan 10, 2023

yudukikun5120 commented Jan 10, 2023


		type Feature = (typeof Feature)[number]

		const isFeature = (key: string): key is Feature => key in Feature

refactor: abstraction for features #558

Are you sure you want to change the base?

refactor: abstraction for features #558

Conversation

yudukikun5120 commented Dec 17, 2022 • edited Loading

mkobayashime left a comment

Choose a reason for hiding this comment

yudukikun5120 commented Jan 9, 2023

mkobayashime commented Jan 10, 2023

mkobayashime Jan 10, 2023

Choose a reason for hiding this comment

yudukikun5120 Jan 10, 2023

Choose a reason for hiding this comment

codeclimate bot commented Jan 10, 2023

yudukikun5120 commented Jan 10, 2023

yudukikun5120 commented Dec 17, 2022 •

edited

Loading