Skip to content

Fix comments after dropping python 3.7 #2406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix comments after dropping python 3.7 #2406

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ jobs:
strategy:
fail-fast: false
matrix:
# This uses old arcticdb versions which won't work on python < 3.12
# This uses old arcticdb versions which won't work on python >= 3.12. So we test up to 3.11.
python3: ${{fromJson(inputs.run_full_matrix_of_persistent_tests && '[8, 9, 10, 11]' || '[11]')}}
arcticdb_version: ["oldest", "latest"]
include:
Expand All @@ -262,7 +262,7 @@ jobs:
strategy:
fail-fast: false
matrix:
# This uses old arcticdb versions which won't work on python < 3.12
# This uses old arcticdb versions which won't work on python >= 3.12. So we test up to 3.11.
python3: ${{fromJson(inputs.run_full_matrix_of_persistent_tests && '[8, 9, 10, 11]' || '[11]')}}
arcticdb_version: ["oldest", "latest"]
include:
Expand Down Expand Up @@ -396,7 +396,7 @@ jobs:
strategy:
fail-fast: false
matrix:
# This uses old arcticdb versions which won't work on python < 3.12
# This uses old arcticdb versions which won't work on python >= 3.12. So we test up to 3.11.
python3: ${{ fromJson(inputs.run_full_matrix_of_persistent_tests && '[8, 9, 10, 11]' || '[11]') }}
arcticdb_version: ["oldest", "latest"]
include:
Expand All @@ -421,7 +421,7 @@ jobs:
strategy:
fail-fast: false
matrix:
# This uses old arcticdb versions which won't work on python < 3.12
# This uses old arcticdb versions which won't work on python >= 3.12. So we test up to 3.11.
python3: ${{ fromJson(inputs.run_full_matrix_of_persistent_tests && '[8, 9, 10, 11]' || '[11]') }}
arcticdb_version: ["oldest", "latest"]
include:
Expand Down
6 changes: 2 additions & 4 deletions python/tests/util/mark.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,11 +226,9 @@ def getenv_strip(env_var_name: str, default_value: Optional[str] = None) -> Opti

FORK_SUPPORTED = pytest.mark.skipif(WINDOWS, reason="Fork not supported on Windows")

## MEMRAY supports linux and macos and python 3.8 and above
## MEMRAY supports linux and macos
MEMRAY_SUPPORTED = MACOS or LINUX
MEMRAY_TESTS_MARK = pytest.mark.skipif(
not MEMRAY_SUPPORTED, reason="MEMRAY supports linux and macos and python 3.8 and above"
)
MEMRAY_TESTS_MARK = pytest.mark.skipif(not MEMRAY_SUPPORTED, reason="MEMRAY supports linux and macos")

ZONE_INFO_MARK = pytest.mark.skipif(sys.version_info < (3, 9), reason="zoneinfo module was introduced in Python 3.9")

Expand Down
Loading