CD-i: Add Cursor Blink #13624
Open
CD-i: Add Cursor Blink #13624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Intends to fix mamedev#13522. This fixes an error in mcd212.h which dropped the middle bit of the Cursor's ON timer. I changed it to use bitshifted binary which more clearly is readable as a correctly shifted mask.
ajrhacker
reviewed
Apr 26, 2025
|
@ajrhacker do you have any further issues with this? |
cuavas
requested changes
Jun 16, 2025
Comment on lines
+239
to
+241
| // Cursor State | ||
| uint16_t m_blink_time; // Counter that tracks how long since the last m_blink_active last changed. | ||
| bool m_blink_active = false; |
There was a problem hiding this comment.
You haven’t registered these new data members for saved states in device_start. Please check that all data members that hold live state are registered for saved states.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intends to fix #13522.
This also fixes an error in mcd212.h which dropped the middle bit of the Cursor's ON timer. I changed it to use bitshifted binary which more clearly is readable as a correctly shifted mask.
The time calculation was produced algebraically by following the description on the page in the comment. It should work for NTSC as well as PAL, however NTSC games have not been tested since NTSC games are generally unsupported at the moment.
To test, I recommend the Validation Disc (Europe). Use the Cursor Blink test (described in #13522), and verify the timing of the blinks correctly matches the description for each test.
This also rewrites the cursor's draw logic to be slightly cleaner.