add tk10 keyboard device for apple ii clones

[goldnchild]

I found a schematic of the TK10 keyboard and made a device for it.

The rom can be found as part of the am64 apple II clone in apple2.cpp.

[rb6502]

If it's part of the AM64 machine, then you should just hook it up to the AM64. Also, unless the keyboard was also used on non-Apple machines you can just put it in src/mame/apple.

[cuavas]

This isn’t much use if it isn’t actually attached to anything. The device won’t be linked since there’s nothing referenced in the translation unit, so it won’t appear in -listxml or detect things with -romident, etc.

Also it should be in src/mame/apple.

[cuavas]

You should lift the p2_r out of the loop.

[cuavas]

Do these keys really have blank key caps? It’s bad to have inputs that lack either PORT_NAME or PORT_CHAR.

[cuavas]

This doesn’t match the path.

[cuavas]

Conventionally, configuration members come before other stuff.

[cuavas]

Please don’t copy/paste this meaningless comment. Also, please add ATTR_COLD for typical cold lifecycle member functions as @holub has done for most existing devices.

[goldnchild]

If it's part of the AM64 machine, then you should just hook it up to the AM64. Also, unless the keyboard was also used on non-Apple machines you can just put it in src/mame/apple.

I wanted to check with you on changes to apple2.cpp.

adding a member variable to hold the value of tk10 reset line.

void apple2_state::tk10_data_write(u8 data)
{
if (m_maincpu->total_cycles() < 25000)
{
return;
}

	if (data & 0x80)
	{
		m_transchar = data & 0x7f;
		m_strobe = 0x80;
	}

}

void apple2_state::tk10_reset_write(u8 data)
{
m_tk10_reset_data = data;
}

TIMER_DEVICE_CALLBACK_MEMBER(apple2_state::apple2_interrupt_tk10)
{
basically the same as the regular function, only this time using the tk10 reset line
}

void apple2_state::am64(machine_config &config)
{
apple2p(config);
m_scantimer->configure_scanline(FUNC(apple2_state::apple2_interrupt_tk10), "screen", 0, 1);

tk10_keyboard_device &tk10(TK10_KEYBOARD(config, "tk10", 0));
tk10.data_write_cb().set(FUNC(apple2_state::tk10_data_write));
tk10.reset_write_cb().set(FUNC(apple2_state::tk10_reset_write));

}

I didn't want to touch any of the existing code, like removing the normal keyboard.
// config.device_remove(A2_KBDC_TAG);

When you switch the keyboard selection under the Input Menu, the normal keyboard can be deactivated and the tk10 can be activated.