Add Casio WK-1600/1800 #12957
Draft
Add Casio WK-1600/1800 #12957
+1,164
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
---------- Casio WK-1800 [Edward d-tech, Devin Acker] New working clones ---------- Casio WK-1600 [Edward d-tech, Devin Acker]
cuavas
reviewed
Nov 10, 2024
Comment on lines
+210
to
+211
| if(inputnum == H8_INPUT_LINE_TEND0 || inputnum == H8_INPUT_LINE_TEND1) | ||
| m_tend_cb[inputnum - H8_INPUT_LINE_TEND0](state); |
There was a problem hiding this comment.
Why have you got input lines piped straight to callbacks? That’s rather suspect.
There was a problem hiding this comment.
This is taken directly from other H8 devices that already implement TEND0/TEND1 (i.e. h83002_device, h83003_device)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm opening this as a draft for now due to issues with the WK-1800 floppy drive, any help would be appreciated:
New working machines
Casio WK-1800 [Edward d-tech, Devin Acker]
New working clones
Casio WK-1600 [Edward d-tech, Devin Acker]