Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to Yamaha MU50 internal layout #12735

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

felipesanches
Copy link
Contributor

Internal layout in this PR:
Screenshot from 2024-09-05 07-57-21

And with external layout (available at https://github.com/ArqueologiaDigital/MAME_synths_artwork/tree/main/mu50):
Screenshot from 2024-09-05 08-12-03

@cuavas
Copy link
Member

cuavas commented Sep 5, 2024

I really don’t want to go in the direction of having SVG data that isn’t readily human-readable in internal layouts. So far, I’ve been trying to limit it to relatively simple shapes, coordinates that are simple to understand at a glance (nothing that needs a large number of significant figures), no unnecessary CSS, and no unnecessary transforms.

The idea of supporting embedded SVG in internal layouts wasn’t to have them bloated with stuff that really belongs in external artwork – it was just to allow people to add geometric shapes beyond circles and rectangles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants