Fixes/ROMs for Roland stuff #12555
Merged
Fixes/ROMs for Roland stuff #12555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galibert
reviewed
Jul 8, 2024
src/mame/roland/roland_jv80.cpp
Outdated
| { | ||
| map(0x08000, 0x09fff).ram(); | ||
| map(0x00000, 0x08000).rom().region("maincpu", 0); |
There was a problem hiding this comment.
That should be 0x7fff and not 0x8000. Recommend you try a mame -valid before doing a submission, it doesn't take long and avoids duh-moments.
There was a problem hiding this comment.
Hi, just pushed a fix, thanks for the tip!
I'm making my first contributions and I'm still trying to learn how all the internal works, sorry.
|
@galibert I just checked the available rom zip files for the new mame version and the ones for the d50 got entirely replaced with my file only, instead of just adding it to the existing ones |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames
rolandpcmintoroland_lpto make it distinct from other PCM chipsAdds a skeleton for the GP (TC6116) chip
Fixes the T6963C LCD controller by adding ram read support and correct text/graphics enable register handling. This makes the Roland D-70 behave correctly with message popups
Fixes the allocation of waveroms in the Roland D-70
Adds the first ever dump of the internal mask ROM of the Roland D-50 CPU
Fixes the memory map of the JV80 and wires up the PCM chip skeleton
Adds a skeleton and ROM dumps for the RD-500