Unpin cryptography, python, and add make to environment-dev.yml #3352
Conversation
dev/environment-dev.yml
Outdated
| @@ -24,7 +25,7 @@ dependencies: | |||
| # micromamba dependencies | |||
| - cli11 >=2.2 | |||
| # micromamba test dependencies | |||
| - python =3.9 # Some not too recent version | |||
| - python | |||
There was a problem hiding this comment.
I actually don't know the reason of pinning python here... Maybe this is hiding some incompatibilities. Let's see what happens with the CI.
There was a problem hiding this comment.
Ok I think unpinning python makes it get fmt 11 everywhere while #3368 only handles a part of it in the codebase.
I suggest restoring python pinning for this PR and handle fmt 11 in another one (I will open an issue for it).
Is it something blocking at the moment or more like an enhancement opening for more possibilities?
That being said, that's only showing one issue of possible other ones when unpinning python, so that would be something to check within the fixing PR.
|
The failures seem to be related to using |
A few other elements were required, as observed in: mamba-org#3352 Signed-off-by: Julien Jerphanion <[email protected]>
|
Missing elements for the support of fmt 11 are introduced in #3371. |
* build: Support fmt 11 A few other elements were required, as observed in: #3352 Signed-off-by: Julien Jerphanion <[email protected]> * Unpin python on 3.9 Signed-off-by: Julien Jerphanion <[email protected]> * ci: use libcxx<18 for macOS Signed-off-by: Julien Jerphanion <[email protected]> * Add TODO comment Co-authored-by: Hind-M <[email protected]> Signed-off-by: Julien Jerphanion <[email protected]> --------- Signed-off-by: Julien Jerphanion <[email protected]>
|
Now that #3371 is merged, rebasing should hopefully fix the failures this time :) |
I'm using this in some Docker containers as part of my devcontainer config, and they don't include
make. Also, cryptography<40 is not needed anymore (see conda/conda-content-trust#57).I also unpinned
pythonso you can use it on any solvable Python environment without overriding to 3.9.mitmproxyanddoctestare not available on linux-aarch64, so that fails, but the selector syntax only allows OS-level names, not architectures, so I can't omit those.