-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create new environment using a remote mamba solver #141
base: main
Are you sure you want to change the base?
Conversation
The code completion in the environment editor can be activated with CTRL-space.
530a16c
to
2da6178
Compare
gator1.mp4 |
Thanks a lot for this awesome feature @mariobuikhuizen I'll try to review it in the coming days. One design question from the demo (thanks for it); did you think about various design? For example, does it make sense to open a new mainwidgetarea containing the editor with the button as toolbar button? The idea would be to create/edit environment file in a standalone widget directly from the filebrowser in addition to the demo you are presenting. |
That sounds like a good idea @fcollonval, I'll look into that. |
Thanks @hbcarlos! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey thanks for this awesome feature. I left some comments; mainly I think the code could be simplified by reusing the import
feature directly. And I'm worry that fetching the quetz server should be proxied through the server extension instead of being done on the frontend to avoid CORS errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mariobuikhuizen I added some comments.
and make look and feel more native.
This way the component automatically gets a displayName.
2c81ae4
to
72a2f70
Compare
Co-authored-by: Frédéric Collonval <[email protected]>
I discovered an issue with setting arguments with the standalone navigator with jupyter_server 1.9 (in 1.6.1 it works). Taking a look at that now. |
I think it's an issue in jupyter-server: jupyter-server/jupyter_server#550 |
Point
quetz_url
andquetz_solve_url
inpackages/common/src/components/CondaHints.ts
to your Quetz server/solver.On the Quetz server with the solver add:
to
config.toml
The code completion in the environment editor can be activated with CTRL-space.